[llvm] r226746 - [canonicalization] Refactor how we create new stores into a helper

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Jan 21 18:18:12 PST 2015


> On 2015-Jan-21, at 16:39, Chandler Carruth <chandlerc at gmail.com> wrote:
> 
> 
> On Wed, Jan 21, 2015 at 3:45 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
> [canonicalization] Refactor how we create new stores into a helper
> function. This is a bit tidier anyways and will make a subsquent patch
> simpler as I want to add another case to this combine.
> 
> I didn't end up needing this, but it seems cleaner to leave it in. Let me know if anyone prefers the old code.

New code looks better to me.  Might be cleaner without the return value
if you're not using it, though.



More information about the llvm-commits mailing list