Yes, please split it. If there is a good logical split point -- always try to do that. Code reviews often have O(N^2) complexity, you don't want N to be too large. http://reviews.llvm.org/D6056 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/