[PATCH] merge consecutive stores of extracted vector elements (PR21711)

[Quentin Colombet]

Hi Sanjay,

This looks almost good. Indeed, I believe we can refactor the code to avoid some code duplication. See my inline comment.

Thanks,
-Quentin


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9950
@@ +9949,3 @@
+
+    // Make sure we have a legal type and something to merge.
+    if (NumElem < 2)
----------------
>From this point, AFAICT, the code is exactly very similar to the constant version.
Please refractor the code with a helper method.

http://reviews.llvm.org/D6850

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/