[llvm] r226671 - Fixed a bug with how we determine bitset indices.

[George Burgess IV]

Diff containing only the test case is attached — I’ll start including test cases for changes like this in the future. :)

Is the crash-the-compiler style of test (given the circumstances) acceptable, or do you think it would be best to verify the compiler’s output as well?

George

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cfl-index-fix-test.diff
Type: application/octet-stream
Size: 1754 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150121/72abd011/attachment.obj>
-------------- next part --------------

> On Jan 21, 2015, at 11:42 AM, Hal Finkel <hfinkel at anl.gov> wrote:
> 
> Do you have a test case?
> 
> -Hal
> 
> ----- Original Message -----
>> From: "George Burgess IV" <george.burgess.iv at gmail.com>
>> To: llvm-commits at cs.uiuc.edu
>> Sent: Wednesday, January 21, 2015 10:37:21 AM
>> Subject: [llvm] r226671 - Fixed a bug with how we determine bitset indices.
>> 
>> Author: gbiv
>> Date: Wed Jan 21 10:37:21 2015
>> New Revision: 226671
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=226671&view=rev
>> Log:
>> Fixed a bug with how we determine bitset indices.
>> 
>> 
>> Modified:
>>    llvm/trunk/lib/Analysis/CFLAliasAnalysis.cpp
>> 
>> Modified: llvm/trunk/lib/Analysis/CFLAliasAnalysis.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/CFLAliasAnalysis.cpp?rev=226671&r1=226670&r2=226671&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Analysis/CFLAliasAnalysis.cpp (original)
>> +++ llvm/trunk/lib/Analysis/CFLAliasAnalysis.cpp Wed Jan 21 10:37:21
>> 2015
>> @@ -774,7 +774,7 @@ static Optional<StratifiedAttr> valueToA
>> }
>> 
>> static StratifiedAttr argNumberToAttrIndex(unsigned ArgNum) {
>> -  if (ArgNum > AttrMaxNumArgs)
>> +  if (ArgNum >= AttrMaxNumArgs)
>>     return AttrAllIndex;
>>   return ArgNum + AttrFirstArgIndex;
>> }
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> -- 
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory