[PATCH] Moar string interceptors: strstr, strcasestr, strcspn, strpbrk

Maria Guseva m.guseva at samsung.com
Wed Jan 21 09:09:55 PST 2015


Hi all
I've prepared new patch with fixes suggested in glider's review. I've also done merge with recent trunk. Please take a look.

Regarding splitting the patch:
indeed there two main changes in this patch:

1. new strict_string_checks run-time flag introduced and applied for existing common, asan, msan and tsan interceptors. New asan tests added for this flag.
2. new interceptors added as it was suggested in original request(strstr, strcasestr, strcspn, strpbrk) with strict_string_checks flag supported. New common and asan tests added for them.

If it wil be easier I can split patch in these two correspondingly. If so should I attach both to this revision? Or create new one?


http://reviews.llvm.org/D6056

Files:
  lib/asan/asan_interceptors.cc
  lib/msan/msan_interceptors.cc
  lib/sanitizer_common/sanitizer_common_interceptors.inc
  lib/sanitizer_common/sanitizer_flags.inc
  lib/sanitizer_common/sanitizer_platform_interceptors.h
  lib/tsan/rtl/tsan_interceptors.cc
  test/asan/TestCases/atoi_strict.c
  test/asan/TestCases/atol_strict.c
  test/asan/TestCases/atoll_strict.c
  test/asan/TestCases/strcasestr-1.c
  test/asan/TestCases/strcasestr-2.c
  test/asan/TestCases/strcasestr_strict.c
  test/asan/TestCases/strcat_strict.c
  test/asan/TestCases/strchr_strict.c
  test/asan/TestCases/strcspn-1.c
  test/asan/TestCases/strcspn-2.c
  test/asan/TestCases/strcspn_strict.c
  test/asan/TestCases/strncat_strict.c
  test/asan/TestCases/strpbrk-1.c
  test/asan/TestCases/strpbrk-2.c
  test/asan/TestCases/strpbrk_strict.c
  test/asan/TestCases/strstr-1.c
  test/asan/TestCases/strstr-2.c
  test/asan/TestCases/strstr_strict.c
  test/asan/TestCases/strtol_strict.c
  test/asan/TestCases/strtoll_strict.c
  test/asan/Unit/lit.site.cfg.in
  test/sanitizer_common/TestCases/strcasestr.c
  test/sanitizer_common/TestCases/strcspn.c
  test/sanitizer_common/TestCases/strpbrk.c
  test/sanitizer_common/TestCases/strstr.c

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6056.18524.patch
Type: text/x-patch
Size: 41863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150121/758e8160/attachment.bin>


More information about the llvm-commits mailing list