[PATCH] [mips] Add new error message and improve testing for parsing the .module directive.

Toma Tabacu toma.tabacu at imgtec.com
Wed Jan 21 07:49:52 PST 2015


Hi dsanders,

We used to silently ignore any empty .module's and we used to give an error saying that we found
an "unexpected token at start of statement" when the value of the option wasn't an identifier (e.g. if it was a number).

We now give an error saying that we "expected .module option identifier" in both of those cases.

I also fixed the other tests in mips-abi-bad.s, which all seemed to be broken.

http://reviews.llvm.org/D7095

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  test/MC/Mips/mips-abi-bad.s

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7095.18517.patch
Type: text/x-patch
Size: 4308 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150121/7832fa8c/attachment.bin>


More information about the llvm-commits mailing list