[PATCH] Bug 21886 - MCJIT/ELF now support MSVC C++ mangled symbol

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Jan 21 07:06:22 PST 2015


On 21 January 2015 at 09:21, Benoit Belley <benoit.belley at autodesk.com> wrote:
> No, I don't have direct commit access the the llvm repository. Would "arc land" work once the revision is approved ? (I'll be watching the build bots afterward...)

Not sure. I would say try and see :-)


> Thanks for the review! :-)
>
> If you give me a few hints regarding the proper place to put the GNU-style symbol versioning replacement, I might take a stab at it as a follow-up to this patch.

Since it is a property of the assembly, it might be somewhere in
lib/MC/MCParser. I will probably have to set a flag that the ELF
writer can then check instead of checking the name directly.

Doing so should fix pr22275.

Since using quoted symbol names is a MC extension over the GNU
assembler, we should probably not set the flag for "@@@" so that we
can still represent the test in pr22275 as assembly.

Cheers,
Rafael



More information about the llvm-commits mailing list