[llvm] r226490 - IR: Remove direct comparisons against Metadata::Storage, NFC

Timur Iskhodzhanov timurrrr at google.com
Wed Jan 21 04:25:49 PST 2015


Re: updating CodingStandards
Deferring to you guys, as you seem to already have much better
understanding of the issue than I have :)

On Tue Jan 20 2015 at 10:20:57 PM Reid Kleckner <rnk at google.com> wrote:

> On Tue, Jan 20, 2015 at 10:57 AM, Duncan P. N. Exon Smith <
> dexonsmith at apple.com> wrote:
>
>> Tried and failed in r226571 (see revert in r226579).
>>
>> Fixing the type of the enum and then using it in a bitfield that
>> doesn't have space for the underlying type spawns GCC warnings
>> (link in the revert commit message).
>
>
> I would say, let's disable the gcc warning, but it looks like they lack a
> -W flag for it:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51242
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150121/21698dd4/attachment.html>


More information about the llvm-commits mailing list