[PATCH] [zorg] Fix get slave environment in LLDB Windows builder.

Rick Foos rfoos at codeaurora.org
Tue Jan 20 17:49:34 PST 2015


http://reviews.llvm.org/D7077

Sorry about RemoveDirectory. It was part of some internal modifications.

I change clean to the RemoveDirectory step I'm going to add in the 
generic cmake builder (working, coming very soon).

Thanks
Rick

On 01/20/2015 07:05 PM, Galina wrote:
> Hi Rick,
>
> Please see my comment in-line.
>
> Also, could you re-generate the patch, please?
> The attached one seems broken.
>
> Thanks
> Glaina.
>
>
> REPOSITORY
>    rL LLVM
>
> ================
> Comment at: zorg/buildbot/builders/LLDBBuilder.py:87
> @@ -86,1 +86,3 @@
> +                           doStepIf=clean,
> +                           workdir='.'))
>   
> ----------------
> You have imported RemoveDirectory. Did you plan using it here instead of the direct use of the Windows-specific command?
>
> http://reviews.llvm.org/D7017
>
> EMAIL PREFERENCES
>    http://reviews.llvm.org/settings/panel/emailpreferences/
>
>

-- 
Rick Foos
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project




More information about the llvm-commits mailing list