[llvm] r226570 - IR: Store StorageType as an unsigned bitfield

[Duncan P. N. Exon Smith]

> On 2015 Jan 20, at 08:05, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> 
>> On 2015 Jan 20, at 08:00, Benjamin Kramer <benny.kra at gmail.com> wrote:
>> 
>> 
>>> On 20.01.2015, at 16:51, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>>> 
>>> Author: dexonsmith
>>> Date: Tue Jan 20 09:51:14 2015
>>> New Revision: 226570
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=226570&view=rev
>>> Log:
>>> IR: Store StorageType as an unsigned bitfield
>>> 
>>> Use `unsigned` instead of `StorageType` for the bitfield to prevent MSVC
>>> from treating the top bit of the bitfield as a sign bit.
>> 
>> Can you just give the enum a type? Losing type information this way is really ugly and not needed in the C++11 days.
> 
> That's better.  r226571.
> 

Actually, not better.  Reverted in r226579.  Apparently GCC doesn't
like it very much [1].

[1]: http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/20260