[PATCH][mips] Add registers and ALL check prefix to octeon test, case.

Kai Nacke kai.nacke at redstar.de
Tue Jan 20 08:15:50 PST 2015


Thanks. Committed with the proposed changes as r226574.

On 19.01.2015 16:19, Daniel Sanders wrote:
> LGTM with a nit.
>> --- a/test/CodeGen/Mips/octeon.ll +++ b/test/CodeGen/Mips/octeon.ll @@
>> -1,15 +1,14 @@ -; RUN: llc -O1 < %s -march=mips64 -mcpu=octeon |
>> FileCheck %s -check-prefix=OCTEON -; RUN: llc -O1 < %s -march=mips64
>> -mcpu=mips64 | FileCheck %s -check-prefix=MIPS64 +; RUN: llc -O1 < %s
>> -march=mips64 -mcpu=octeon | FileCheck %s -check-prefix=ALL
>> -check-prefix=OCTEON +; RUN: llc -O1 < %s -march=mips64 -mcpu=mips64 |
>> FileCheck %s -check-prefix=ALL -check-prefix=MIPS64 define i64
>> @addi64(i64 %a, i64 %b) nounwind { entry: -; OCTEON-LABEL: addi64: +;
>> ALL-LABEL: addi64: ; OCTEON: jr $ra ; OCTEON: baddu $2, $4, $5 -;
>> MIPS64-LABEL: addi64: -; MIPS64: daddu -; MIPS64: jr -; MIPS64: andi
>> +; MIPS64: daddu $1, $4, $5 +; MIPS64: jr $ra +; MIPS64: andi $2, $1,
>> 255 %add = add i64 %a, %b %and = and i64 %add, 255 ret i64 %and
> The $1 is unpredictable. You need to use a filecheck variable like so: ;
> MIPS64: daddu $[[T0:[0-9]+]], $4, $5 ; MIPS64: jr $ra ; MIPS64: andi $2,
> $[[T0]], 255 ________________________________________ From: Kai Nacke
> [kai.nacke at redstar.de] Sent: 19 January 2015 06:24 To: llvm-commits;
> Daniel Sanders Subject: [PATCH][mips] Add registers and ALL check prefix
> to octeon test, case. Hi Daniel! I added the registers for the MIPS64
> case in the remaining test cases and I also introduced the ALL check
> prefix. Please review. Regards, Kai
> _______________________________________________ llvm-commits mailing
> list llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list