[PATCH] Replace the bitfield of SubtargetFeatures with a BitVector

Chandler Carruth chandlerc at gmail.com
Tue Jan 20 01:14:52 PST 2015


FWIW, I don think this is generally the right direction.

Some simplifying thoughts:

1. Look at fixing the incompatible usages prior to changing the type. For example, putting the bits into a union seems like a bad idea anyways.

2. Is the number of bits a compile time thing? If so, then std::bitset would work much better than BitVector and likely avoid some of the complexity here. There is also SmallBitVector if the number is dynamic but usually small.


http://reviews.llvm.org/D7065

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list