[PATCH] Factor out a splitSwitchCase() function so that it can be reused.

Chandler Carruth chandlerc at gmail.com
Tue Jan 20 00:44:45 PST 2015


LGTM, thanks for clarifying why the split is useful (it seems really arbitrary from this change alone).


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:2433-2436
@@ -2441,8 +2432,6 @@
     volatile double LDensity =
-       (double)LSize.roundToDouble() /
-                           (LEnd - First + 1ULL).roundToDouble();
+        LSize.roundToDouble() / (LEnd - First + 1ULL).roundToDouble();
     volatile double RDensity =
-      (double)RSize.roundToDouble() /
-                           (Last - RBegin + 1ULL).roundToDouble();
-    volatile double Metric = Range.logBase2()*(LDensity+RDensity);
+        RSize.roundToDouble() / (Last - RBegin + 1ULL).roundToDouble();
+    volatile double Metric = Range.logBase2() * (LDensity + RDensity);
     // Should always split in some non-trivial place
----------------
You're also clearly doing some other cleanups in this patch. Feel free to split these out, or not (i don't *really* care) but at least call them out in the commit log.

http://reviews.llvm.org/D7064

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list