Looks OK, but where are the positive tests? Assuming LLVM already has those somewhere? REPOSITORY rL LLVM http://reviews.llvm.org/D7057 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/