[compiler-rt] r226452 - [sanitizer] Simplify code in flag parser.

Evgeniy Stepanov eugeni.stepanov at gmail.com
Mon Jan 19 02:54:37 PST 2015


Author: eugenis
Date: Mon Jan 19 04:54:36 2015
New Revision: 226452

URL: http://llvm.org/viewvc/llvm-project?rev=226452&view=rev
Log:
[sanitizer] Simplify code in flag parser.

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.cc?rev=226452&r1=226451&r2=226452&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_flag_parser.cc Mon Jan 19 04:54:36 2015
@@ -63,10 +63,7 @@ void FlagParser::parse_flag() {
   }
 
   bool res = run_handler(name, value);
-  if (!res) {
-    Printf("Flag parsing failed.");
-    Die();
-  }
+  if (!res) fatal_error("Flag parsing failed.");
   InternalFree(name);
   InternalFree(value);
 }
@@ -108,7 +105,7 @@ bool FlagParser::run_handler(const char
 
 void FlagParser::RegisterHandler(const char *name, FlagHandlerBase *handler,
                                  const char *desc) {
-  CHECK(n_flags_ < kMaxFlags);
+  CHECK_LT(n_flags_, kMaxFlags);
   flags_[n_flags_].name = name;
   flags_[n_flags_].desc = desc;
   flags_[n_flags_].handler = handler;





More information about the llvm-commits mailing list