[PATCH] Improve DAG combine pass on certain IR vector patterns

Chandler Carruth chandlerc at google.com
Fri Jan 16 15:02:51 PST 2015


On Fri, Jan 16, 2015 at 2:42 PM, Fiona Glaser <fglaser at apple.com> wrote:

>
> On Jan 16, 2015, at 2:33 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
>
>
> On Fri, Jan 16, 2015 at 2:27 PM, Fiona Glaser <fglaser at apple.com> wrote:
>
>> Is this okay? I omitted the prefix stuff because both AVX and AVX2 should
>> generate identical output in this test.
>
>
> Just add the few cases to the existing appropriate vector-shuffle file,
> and run utils/update_x86_llc_test_checks.py to generate the new FileCheck
> bits. It does commoning between AVX1 and AVX2 when they're the same.
>
>
> Okay, I hope I did this right.
>

This is the right idea, but the wrong file:
--- a/test/CodeGen/X86/vector-shuffle-256-v32.ll +++
b/test/CodeGen/X86/vector-shuffle-256-v32.ll

You probably want vector-shuffle-256-v8.ll, as your tests are producing
v8f32 vectors.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150116/f48a5d25/attachment.html>


More information about the llvm-commits mailing list