[PATCH] Move the IsIndirect flag from DIVariable into DIExpression.

David Blaikie dblaikie at gmail.com
Fri Jan 16 10:06:29 PST 2015


(might be easier to review/commit by adding the expression handling then just removing the flag as dead code afterwards, but I'm not sure - it's not bad the way you've got it either)


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp:237
@@ -237,3 +236,3 @@
     // We assume that pointers are always in an addressable register.
-    if (Indirect || MLoc.isIndirect())
+    if (MLoc.isIndirect())
       // FIXME: We have no reasonable way of handling errors in here. The
----------------
Do we need MachineLocation::isIndirect anymore?

Hmm, I guess I do vaguely recall this being here before I added the other indirect flag... but I forget what it might be for, etc.

http://reviews.llvm.org/D6986

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list