[PATCH] Add Exported flag.

[Lang Hames]

Thanks very much for the review Eric.

Committed with changes as requested in r226217.

Cheers,
Lang.

On Thu, Jan 15, 2015 at 11:02 AM, Eric Christopher <echristo at gmail.com>
wrote:

>
> +    if (Visibility != ELF::STV_DEFAULT && Visibility !=
> ELF::STV_PROTECTED)
>
> Can you comment this? I actually had to read it twice to make sure you
> weren't saying default isn't exported. Or maybe make a more positive
> statement?
>
> Otherwise LGTM.
>
> -eric
>
> On Wed Jan 14 2015 at 5:00:30 PM Lang Hames <lhames at gmail.com> wrote:
>
>> There's no pleasing some people. ;)
>>
>> - Lang.
>>
>>
>>
>> On Wed, Jan 14, 2015 at 4:40 PM, David Blaikie <dblaikie at gmail.com>
>> wrote:
>>
>>> If complain about the lack of tests, but this is lacking the entire
>>> patch (forgot to add the attachment) ;)
>>> On Jan 14, 2015 4:18 PM, "Lang Hames" <lhames at gmail.com> wrote:
>>>
>>>> Hi All,
>>>>
>>>> The attached patch adds an "SF_Exported" flag to libObject Symbols. The
>>>> new Orc JIT infrastructure relies on this to correctly resolve symbols for
>>>> TUs that have been broken up.
>>>>
>>>> This patch is based on work by Anthony Pesch - thanks Anthony!
>>>>
>>>> No test case - None of the command-line tools query this flag, and
>>>> there are no libObject unit tests yet. (Perhaps we should discuss adding
>>>> some - we just need to figure out the most reasonable way to construct the
>>>> ObjectFile instances). This can be tested indirectly by a simple Orc
>>>> regression test once Orc is in tree: Have two "static foo" functions in
>>>> different modules and verify that calls to them resolve correctly.
>>>>
>>>> Cheers,
>>>> Lang.
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150115/7526085b/attachment.html>