[PATCH] statepoint-call-lowering: test relocate int and array
Philip Reames
listmail at philipreames.com
Thu Jan 15 10:35:19 PST 2015
I am completely missing all context on what you're trying to accomplish with these tests. What is "this" that is supposed to work?
================
Comment at: test/CodeGen/X86/statepoint-call-lowering.ll:80
@@ +79,3 @@
+; CHECK-LABEL: test_relocate_integer
+; Check that relocation of an integer is lowered correctly
+; CHECK: pushq %rax
----------------
Er, this is *not* a relocation of an integer. It's the relocation of a *pointer* to an integer.
================
Comment at: test/CodeGen/X86/statepoint-call-lowering.ll:97
@@ +96,3 @@
+; CHECK-LABEL: test_relocate_array
+; Check that relocation of an array of integers is lowered correctly
+; CHECK: pushq %rax
----------------
This is testing the relocation of *a pointer* to an array. Is that what you intended?
http://reviews.llvm.org/D6989
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list