[PATCH] [AVX-512] - Add FMA instruction with Rounding mode

[Mehdi AMINI]

Some minor comments.


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/X86/X86InstrAVX512.td:3547
@@ -3525,1 +3546,3 @@
+}
+
 multiclass avx512_fma3p_forms<bits<8> opc213, bits<8> opc231,
----------------
There are trailing spaces in this hunk.

And I feel it should not be between avx512_fma3p_forms and avx512_fma3p_rm but before or after.

================
Comment at: lib/Target/X86/X86InstrAVX512.td:3583
@@ -3582,3 +3608,2 @@
 
-
 multiclass avx512_fma3p_m132_f<bits<8> opc,
----------------
Is a new line intended?

================
Comment at: test/CodeGen/X86/avx512-fma-intrinsics.ll:248
@@ +247,3 @@
+
+define <16 x float> @test_mask_round_vfmadd512_ps_rrbz_current(<16 x float> %a0, <16 x float> %a1, <16 x float> %a2) {
+  ; CHECK-LABEL: test_mask_round_vfmadd512_ps_rrbz_current
----------------
It seems to me that this is exactly the same test as "test_x86_vfmadd_ps_z". Shouldn't you just update the check in the existing tests?

http://reviews.llvm.org/D6835

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/