[PATCH] Implement mips fast-isel select statement

reed kotler rkotler at mips.com
Wed Jan 14 17:43:25 PST 2015


A regression was fixed here because it shows up in test-suite only after this patch. It's a generic problem caused by a shortcoming in tabelgen whereby you can't mark a side effect of an instruction as it making a register Dead and instead out tablegen marked the mul instruction wirh defs for LO0 and HI0 which causes a problem for the register allocator when trying to allocate register AC0 since LO0 and HI0 are dependent registers.

The solution here for this regression is probably temporary since the proper way is to fix tablegen but that will require some more work and approval.


http://reviews.llvm.org/D6774

Files:
  lib/Target/Mips/MipsFastISel.cpp
  test/CodeGen/Mips/Fast-ISel/mul1.ll
  test/CodeGen/Mips/Fast-ISel/sel1.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6774.18202.patch
Type: text/x-patch
Size: 16947 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150115/4a7f5981/attachment.bin>


More information about the llvm-commits mailing list