[PATCH] [lld] ELF: Support detection of relocation errors during processing
Rui Ueyama
ruiu at google.com
Wed Jan 14 14:58:22 PST 2015
LGTM with these fixes.
REPOSITORY
rL LLVM
================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:424
@@ +423,3 @@
+ for (const auto ref : *definedAtom) {
+ if (std::error_code EC = relHandler.applyRelocation(*writer, buffer,
+ *ai, *ref)) {
----------------
s/EC/ec/
================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:431
@@ -398,1 +430,3 @@
});
+ if (success == false)
+ llvm::report_fatal_error("relocating output");
----------------
if (!success)
http://reviews.llvm.org/D6827
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list