[PATCH] SLPVectorizer: Cache results from memory alias checking.
Arnold Schwaighofer
aschwaighofer at apple.com
Tue Jan 13 08:39:31 PST 2015
LGTM.
I think the discussion about how and whether we should use a caching mechanism in AliasAnalysis should be separate. Some clients already have their own caching strategy (MemoryDependence has its own, for example) and might not want/need the overhead of a caching implementation ...
================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:928
@@ +927,3 @@
+ /// Temporary store for deleted instructions. Instructions will be deleted
+ /// eventually when the BoUpSLP is descructed. This is required to ensure
+ /// that there are no incorrect collisions in the AliasCache, which can happen
----------------
s/descructed/destructed/
http://reviews.llvm.org/D6951
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list