[PATCHES] R600/SI: VI fixes
Marek Olšák
maraeo at gmail.com
Tue Jan 13 03:05:53 PST 2015
Are you sure?
In a nutshell, getMCOpcode does this:
uint16_t x = (uint16_t)-1U;
return x;
I don't think a sign extension occurs with uint16_t.
Marek
On Mon, Jan 12, 2015 at 10:43 PM, Matt Arsenault
<Matthew.Arsenault at amd.com> wrote:
> On 01/12/2015 01:32 PM, Tom Stellard wrote:
>>
>> >+ if (AMDGPUMCInstLower::getMCOpcode(Op32, TRI.ST.getGeneration())
>> > == 65535)
>
> This should compare -1, not the uint16_t value. I don't think this will work
> correctly, the sign extended -1 opcode to int for the compare will not work
> as expected
More information about the llvm-commits
mailing list