[PATCH] AArch64: Relax assert about large shift sizes.

Matthias Braun matze at braunis.de
Mon Jan 12 16:38:58 PST 2015


The radar mentions "llvm-stress --seed=29856" as the source of that program, maybe that just doesn't perform any combining/constant folding. In each case I don't know if we should always rely on constant folding/combining happening, what is with clang -O0 for example?
In any case having an instruction with an undefined result in the IR is no reason for a target to fail an assertion IMO.

Greeting
	Matthias

> On Jan 12, 2015, at 4:17 PM, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
> 
> So.. I'm curious, what happens now? (i.e.: how about a little more explicit testcase?)
> I guess since it's undefined, we care even less anyway..
> 
> Also, you mention it in the comment: I would have expected this to be folded to undef, why didn't it?
> 
> -Ahmed
> 
> 
> http://reviews.llvm.org/D6940
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list