[PATCH] Update multiline.ll testcase to handle (ppc64le) .localentry directive

[David Blaikie]

Actually, wait - the point of that NOT .loc is to check for any .loc
directive, which has arguments and stuff, so .loc{{$}} is too restrictive
and wouldn't catch other .locs

maybe CHECK-NOT:  .loc{{ }}

to force the space? Does that work?

On Mon, Jan 12, 2015 at 2:39 PM, David Blaikie <dblaikie at gmail.com> wrote:

> I think {{$}} is a more idiomatic way to check for end of line (or at
> least it is in that file) - I'm surprised \n works there, actually... but
> good to know I guess.
>
> Otherwise looks fine, please commit.
>
> On Mon, Jan 12, 2015 at 2:23 PM, Will Schmidt <willschm at us.ibm.com> wrote:
>
>> Hi wschmidt, dblaikie,
>>
>> The ppc64le platform will emit a .localentry directive.  this is
>> triggering a false-positive against a CHECK-NOT: .loc  in multiline.ll as
>> seen at
>> http://lab.llvm.org:8011/builders/ppc64le-clang/builds/1
>>
>> <...>
>> <stdin>:31:2: error: CHECK-NOT: string occurred!
>>  .localentry f2, .Ltmp1-.Ltmp0
>>
>> /home/buildbots/ppc64le-clang/clang-ppc64le-1/llvm.src/test/DebugInfo/multiline.ll:17:14:
>> note: CHECK-NOT: pattern specified here
>> ; CHECK-NOT: .loc
>>
>>
>> I didn't see a clear way to call out ".localentry is OK" via check-not,
>> so the change here is to add a simple "\n" to the check-not line.
>>
>> REPOSITORY
>>   rL LLVM
>>
>> http://reviews.llvm.org/D6935
>>
>> Files:
>>   test/DebugInfo/multiline.ll
>>
>> Index: test/DebugInfo/multiline.ll
>> ===================================================================
>> --- test/DebugInfo/multiline.ll
>> +++ test/DebugInfo/multiline.ll
>> @@ -14,7 +14,7 @@
>>
>>
>>  ; CHECK: .loc  1 2 0{{$}}
>> -; CHECK-NOT: .loc
>> +; CHECK-NOT: .loc\n
>>  ; CHECK: .loc  1 3 3 prologue_end{{$}}
>>  ; CHECK-NOT: .loc
>>  ; CHECK: .loc  1 3 9 is_stmt 0{{$}}
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150112/0aac0074/attachment.html>