[PATCH] Peephole optimizer needs optimizeSelect() to keep track of newly created MIs
Quentin Colombet
qcolombet at apple.com
Mon Jan 12 13:58:38 PST 2015
Hi Medhi,
LGTM with small nitpicks.
Thanks,
-Quentin
================
Comment at: include/llvm/Target/TargetInstrInfo.h:609
@@ -608,2 +608,3 @@
virtual MachineInstr *optimizeSelect(MachineInstr *MI,
+ SmallPtrSetImpl<MachineInstr *> &NewMIs,
bool PreferFalse = false) const {
----------------
Please add a comment for the purpose of the new argument.
================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:1890
@@ -1887,1 +1889,3 @@
+ // Register newly created MI
+ NewMIs.insert(NewMI);
----------------
Period at the end of a comment.
http://reviews.llvm.org/D6931
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list