[PATCH] Fix PR22179
David Majnemer
david.majnemer at gmail.com
Sat Jan 10 01:33:47 PST 2015
================
Comment at: lib/Analysis/ScalarEvolution.cpp:1748-1749
@@ +1747,4 @@
+ SCEV::NoWrapFlags OldFlags) {
+ bool CanAnalyze = (Type == scAddExpr) || (Type == scAddRecExpr) ||
+ (Type == scMulExpr);
+ (void) CanAnalyze;
----------------
The extra parens don't really add to readability here and the expression is formatted a little funny, consider using clang-format here.
================
Comment at: lib/Analysis/ScalarEvolution.cpp:1757-1758
@@ +1756,4 @@
+ ScalarEvolution::maskFlags(OldFlags, SignOrUnsignMask);
+ if ((SignOrUnsignWrap == SCEV::FlagNSW) &&
+ (SignOrUnsignWrap != SignOrUnsignMask)) {
+
----------------
Why isn't this just equivalent to `if (SignOrUnsignWrap == SCEV::FlagNSW)` ?
http://reviews.llvm.org/D6914
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list