[PATCH] [ARM] Correct POP reglist handling

Saleem Abdulrasool compnerd at compnerd.org
Fri Jan 9 18:08:47 PST 2015


I agree with jroelofs' suggestion about the test changes.  I think that would make it easier to maintain as well.


REPOSITORY
  rL LLVM

================
Comment at: ../llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6330
@@ -6329,3 +6329,3 @@
   case ARM::tPOP: {
-    bool ListContainsBase;
+    bool ListContainsBase, IsARPop;
     if (checkLowRegisterList(Inst, 2, 0, ARM::PC, ListContainsBase) &&
----------------
The variable here is unnecessary.  I would just inline the call to !isMClass() not the call to validateLDMRegList.

http://reviews.llvm.org/D6819

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list