[PATCH] Fully fix Bug #22115.

[Hal Finkel]

Thanks. With those changes, LGTM.

 -Hal

----- Original Message -----
> From: "Justin Hibbits" <jrh29 at alumni.cwru.edu>
> To: jrh29 at alumni.cwru.edu, hfinkel at anl.gov
> Cc: llvm-commits at cs.uiuc.edu
> Sent: Friday, January 9, 2015 5:26:23 PM
> Subject: Re: [PATCH] Fully fix Bug #22115.
> 
> ================
> Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1163
> @@ +1162,3 @@
> +  // Only used in SVR4 32-bit.
> +  int PBPSI = FI->getPICBasePointerSaveIndex();
> +  if (FI->usesPICBase()) {
> ----------------
> hfinkel wrote:
> > This variable is only used inside the if statement. Why are you
> > creating it out here?
> It's how the others do it (BPSI is identical, which is where I copied
> it from).  I'll fix this one though.
> 
> ================
> Comment at: lib/Target/PowerPC/PPCMachineFunctionInfo.h:123
> @@ -119,3 +122,3 @@
>        MF(MF),
>        UsesPICBase(0) {}
>  
> ----------------
> hfinkel wrote:
> > We don't initialize all of the member variables here, but I'd
> > rather we did. Can you please initialize PICBasePointerSaveIndex
> > here.
> Sure thing.
> 
> http://reviews.llvm.org/D6906
> 
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory