[PATCH] Fully fix Bug #22115.
hfinkel at anl.gov
hfinkel at anl.gov
Fri Jan 9 14:47:45 PST 2015
================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1163
@@ +1162,3 @@
+ // Only used in SVR4 32-bit.
+ int PBPSI = FI->getPICBasePointerSaveIndex();
+ if (FI->usesPICBase()) {
----------------
This variable is only used inside the if statement. Why are you creating it out here?
================
Comment at: lib/Target/PowerPC/PPCMachineFunctionInfo.h:123
@@ -119,3 +122,3 @@
MF(MF),
UsesPICBase(0) {}
----------------
We don't initialize all of the member variables here, but I'd rather we did. Can you please initialize PICBasePointerSaveIndex here.
http://reviews.llvm.org/D6906
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list