[patch] Use the DiagnosticHandler to print diagnostics when reading bitcode.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Jan 9 12:44:32 PST 2015


>> +    M = std::move(*MOrErr);
>
> It's probably better to leave the `if (hasError()) return 1` path in
> here, just to future proof against changes to the diagnosticHandler.
>

The operator* of ErrorOr has an assert, so this is pretty future proof.

Cheers,
Rafael



More information about the llvm-commits mailing list