[PATCH] [lld] ELF: Support detection of relocation errors during processing
Rui Ueyama
ruiu at google.com
Thu Jan 8 15:04:21 PST 2015
REPOSITORY
rL LLVM
================
Comment at: lib/Core/Error.cpp:123
@@ -100,1 +122,3 @@
+}
+
----------------
Instead of adding a new error category for your purpose, I think it would be better to just use make_dynamic_error_code(). It's simpler to use.
================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:285
@@ +284,3 @@
+
+ std::string errStr = Twine(errorStr + " in file " +
+ atom._atom->file().path() +
----------------
This doesn't seems a correct way to use Twine. This should be
(Twine(errorStr) + "in file " ...).str()
instead of
Twine(errorStr + "in file " ...).str()
http://reviews.llvm.org/D6827
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list