[PATCH] [3/3] [SimplifyLibCalls] Refactor str/mem libcall handling: Factor out fortified libcall handling, to remove CGP duplicate

Eric Christopher echristo at gmail.com
Thu Jan 8 10:01:45 PST 2015


LGTM.

Thanks for the work here. One silly nit.

-eric


================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:2249
@@ +2248,3 @@
+
+    // This optimization require DataLayout.
+    if (!DL)
----------------
I know this is copy and paste, but "requires" :)

http://reviews.llvm.org/D6541

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list