[patch][pr19848] Don't create new comdats in CodeGen

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Jan 8 08:33:07 PST 2015


On 8 January 2015 at 03:30, David Majnemer <david.majnemer at gmail.com> wrote:
> I really like this change.  However, don't we need to upgrade existing
> bitcode by inserting stuff into newly made comdats?

I guess so.

It was not initially clear to me that it would be worth it. Old
bitcode files would still work, they would just produce .o files that
would not be as optimized by ELF/COFF linkers.

But the feature is common enough that we should probably upgrade. The
attached patch does that.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 20142 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150108/aad72f5a/attachment.bin>


More information about the llvm-commits mailing list