[PATCH] [SelectionDAG] Allow targets to specify legality of extloads' result type (in addition to the memory type)

[Ahmed Bougacha]

On Wed, Jan 7, 2015 at 3:07 PM, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
> FYI: while changing other targets, I decided to flip the order of
> MemVT and ValVT in [gs]etLoadExtAction. In this patch, we had:
>
>     setLoadExtAction(.., MVT ValVT, MVT MemVT, ..)
>     setTruncStoreAction(MVT ValVT, MVT MemVT, ..)
>
> I think it's more useful to keep "source" and "destination" types
> consistent, that is:
>
>     setLoadExtAction(.., MVT MemVT, MVT ValVT, ..)
>     setTruncStoreAction(MVT ValVT, MVT MemVT, ..)
>
> This avoids having consecutive calls to both, with the same arguments,
> but different ordering.
> I'll also rename them to SrcVT/DestVT to make that clear.

Nevermind, on second thought it's better to stay consistent with the
IR/SelectionDAG value/pointer ordering.
Plus the confusing consecutive calls don't happen that often after all.

Committed r225421.  I'll send a notice to target maintainers to change
their code later, if the buildbots don't complain.

-Ahmed

> Anyway, thanks for the reviews,
>
> -Ahmed
>
>
> On Mon, Dec 8, 2014 at 6:03 AM, hfinkel at anl.gov <hfinkel at anl.gov> wrote:
>> This also looks good to me -- this is the right thing to do -- as you've mentioned, you need to update the other in-tree targets before this lands.
>>
>> http://reviews.llvm.org/D6532
>>
>>