[PATCH] [ARM] Fix large stack alignment codegen bug for ARM and Thumb2 targets

Kristof Beyls kristof.beyls at arm.com
Wed Jan 7 05:16:05 PST 2015


Thanks James, I've updated the patch taking into account your review comments.
The only comment I didn't make a change for is commenting whether Alignment is a log2 value or not, as I feel that that documentation would be overkill - it isn't a log2 value and it should be clear from the context it isn't.


http://reviews.llvm.org/D6844

Files:
  lib/Target/ARM/ARMExpandPseudoInsts.cpp
  lib/Target/ARM/ARMFrameLowering.cpp
  test/CodeGen/ARM/alloc-no-stack-realign.ll
  test/CodeGen/ARM/fold-stack-adjust.ll
  test/CodeGen/ARM/interrupt-attr.ll
  test/CodeGen/ARM/spill-q.ll
  test/CodeGen/ARM/stack-alignment.ll
  test/CodeGen/Thumb2/aligned-spill.ll
  test/CodeGen/Thumb2/thumb2-spill-q.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6844.17853.patch
Type: text/x-patch
Size: 19499 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150107/96ea27b9/attachment.bin>


More information about the llvm-commits mailing list