[PATCH] builtins: avoid duplicating unwind declarations

[Renato Golin]

Hi Slaeem,

I agree we should de-duplicate stuff, but the new behaviour is different in more ways than that. Currently, the personality will be included no matter what headers you have, but with your change, it'll only be included if you do have unwind.h. If I understood correctly, this makes sense, since there's no point in having a personality routine without the unwinding framework, but I just want to make sure this is intentional.

Also, the change from struct to pointer is curious...

cheers,
--renato


================
Comment at: lib/builtins/gcc_personality_v0.c:148
@@ -187,3 +147,3 @@
          uint64_t exceptionClass, struct _Unwind_Exception* exceptionObject,
-         _Unwind_Context_t context)
+         struct _Unwind_Context *context)
 #else
----------------
This change doesn't seem relevant (even if it is correct) to this patch.

http://reviews.llvm.org/D6822

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/