[PATCH] [AVX-512] - Add FMA instruction with Rounding mode

Adam Nemet anemet at apple.com
Tue Jan 6 17:04:24 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/X86/X86ISelLowering.h:374
@@ -373,1 +373,3 @@
 
+      ROUNDMODE,
+
----------------
Hmm, has this been completely thought through?  I may have missed the discussion... 

Looks like you're introducing a new node that if it surrounds an FMA op it changes its rounding mode?

What happens if the two nodes get separated by some transformation?

================
Comment at: lib/Target/X86/X86InstrAVX512.td:3541-3542
@@ +3540,4 @@
+                              X86VectorVTInfo VTI, SDPatternOperator OpNode> {
+  defm v213r : avx512_fma3_round_rrb<opc213, !strconcat(OpcodeStr, "213", VTI.Suffix),
+                              VTI, OpNode>, EVEX_CD8<VTI.EltSize, CD8VF>;
+
----------------
I think that the EVEX_CD8 thing can be written as VTI.CD8TupleForm.

Same later.

http://reviews.llvm.org/D6835

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list