[PATCH] [CodeGen] Add iterator ranges for the MVT::SimpleValueType enum.
Pete Cooper
peter_cooper at apple.com
Tue Jan 6 13:16:49 PST 2015
Hi Ahmed
LGTM with just one change:
+ return mvt_range((MVT::SimpleValueType)0, MVT::LAST_VALUETYPE);
Please add FIRST_VALUETYPE to MVT so that you can use enums on the above line instead of 0. I doubt MVT will ever start from anything other than 0, but its just best to avoid there ever being an issue.
Thanks,
Pete
> On Jan 6, 2015, at 1:06 PM, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:
>
> And another, post-holiday, ping!
>
>
> http://reviews.llvm.org/D6537
>
> Files:
> include/llvm/CodeGen/MachineValueType.h
> lib/Target/X86/X86ISelLowering.cpp
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list