[PATCH] [ARM] Add missing Tag_DIV_use tests.

Charlie Turner charlie.turner at arm.com
Tue Jan 6 10:43:18 PST 2015


Hi Renato, happy new year!

In http://reviews.llvm.org/D6721#105733, @rengolin wrote:

> Could you add a test for A15 or A7 and add a check for that attribute (among others)? Just to make sure we cover all cases.


The A15 and A7 have existing tests for this tag. This patch adds some missing tests for other CPUs.

This test file isn't exhaustive over the cross product of ARM CPUs / architecture variants / command line options and their effects on build attributes. That would be nice, but I don't have time to finish it off, and perhaps it would be better suited to being mechanically generated rather than maintained by hand due to the size of such a test file.

> Otherwise, LGTM.


Thanks, after your blessing of the above, I'll commit.

Thanks for reviewing,
Charlie.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D6721

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list