[PATCH] Add UnitTest to test-suite to check correct handling of large stack alignments
Renato Golin
renato.golin at linaro.org
Tue Jan 6 07:09:39 PST 2015
Hi Kristof,
Is this test supposed to pass or fail on ARM? If pass, how can it test the big-stack issue?
I think that having an extra unit test is never a bad idea, if it tests something as serious as that, but we need to be careful to test platform-specific things right.
If the ranges and sizes vary with the architecture, the test should account for that. If the test is irrelevant in other architectures, it should be disabled on them.
cheers,
--renato
================
Comment at: SingleSource/UnitTests/Makefile:141
@@ -141,1 +140,3 @@
+ ms_struct_pack_layout-1 \
+ large_stack_alignment
endif
----------------
TAB issue. TABs in Makefiles are magic, make sure not to insert spaces instead.
http://reviews.llvm.org/D6845
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list