[PATCH] [X86] Convert esp-relative movs of function arguments to pushes, step 2
Michael Kuperstein
michael.m.kuperstein at intel.com
Tue Jan 6 03:19:31 PST 2015
================
Comment at: lib/Target/X86/X86ConvertMovsToPushes.cpp:285
@@ +284,3 @@
+ for (auto I = DefMI; I != FrameSetup; ++I)
+ if (I->mayStore())
+ return nullptr;
----------------
Argh. This is nonsense. Commented one thing, coded another...
(mayStore() is extremely far from being a strong enough condition to allow this.)
http://reviews.llvm.org/D6789
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list