[PATCH] Colored syntax highlighting for llvm-dwarfdump.

Frederic Riss friss at apple.com
Mon Jan 5 16:24:01 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/DebugInfo/DWARFDebugInfoEntry.cpp:44-47
@@ -41,2 +43,6 @@
     uint32_t abbrCode = debug_info_data.getULEB128(&offset);
+    {
+      WithColor C(OS, syntax::Address);
+      OS << format("\n0x%8.8x: ", Offset);
+    }
 
----------------
I'm not too fond of all the extra scopes, dunno what others think.

If this could be implemented too look like:
```
WithColor(OS, syntax::Address) << format("\n0x%8.8x: ", Offset);
```
I think I'd prefer that (not sure if just adding a conversion operator from WithColor to raw_ostream would do the trick).

http://reviews.llvm.org/D6852

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list