[PATCH] [MIScheduler] Slightly better handling of constrainLocalCopy when both source and dest are local

Quentin Colombet qcolombet at apple.com
Mon Jan 5 11:15:57 PST 2015


Hi Michael,

I am not familiar with that code either but the current patch makes sense to me.
I leave the LGTM to Andy though.

Now looking for a generalization, I guess we could loop over all the local candidate and try to apply the transformation until we looked for all or one work.
I.e.,
Currently, we do:
pick a candidate
try apply

Your patch does:
pick a better candidate
try apply

The generalization would be:
for all candidate:

  try apply
  if success -> exit

Where the list of candidates is the local virtual registers.

Anyhow, Andy would have a much more educated answer.

Thanks,
-Quentin


http://reviews.llvm.org/D6823

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list