[PATCH] [GC] improve testing around gc.relocate and catch a bug
Philip Reames
listmail at philipreames.com
Fri Jan 2 14:37:36 PST 2015
LGTM w/minor comment tweak. Do you want me to submit on your behalf?
================
Comment at: test/CodeGen/X86/statepoint-call-lowering.ll:65
@@ +64,3 @@
+; CHECK-LABEL: test_relocate
+; This is checking that a relocate is not lowered
+; CHECK: pushq %rax
----------------
You're missing something key here. A suggestion:
"This is checking that an *unused* relocate has no code generation impact."
http://reviews.llvm.org/D6824
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list