[PATCH] [Sanitizers] Fix internal_lseek() to work on FreeBSD

Ed Maste emaste at freebsd.org
Fri Jan 2 06:48:04 PST 2015


================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:84
@@ -83,2 +83,3 @@
 // like pread and mmap, as opposed to pread64 and mmap64.
 // Mac and Linux/x86-64 are special.
+#if SANITIZER_FREEBSD || SANITIZER_MAC || \
----------------
This comment is mildly confusing with the addition of FreeBSD to the #if. FreeBSD is "special" in the same way that Mac and Linux/x86-64 are.

The warning above clearly explains the issue. Probably just remove the "Mac and..." comment as it's redundant with the test.

http://reviews.llvm.org/D6825

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list