[PATCH] [llgo] Elide alloca for unused received values in select

Andrew Wilkins axwalk at gmail.com
Tue Dec 30 18:08:05 PST 2014


================
Comment at: irgen/channels.go:136
@@ +135,3 @@
+		}
+		return len(*extract.Referrers()) > 0
+	}
----------------
pcc wrote:
> axw wrote:
> > pcc wrote:
> > > There could in principle be multiple `extract` referrers. With this code you end up checking only the first one.
> > The loop and index check should take care of multiple extract instructions. I don't think there would ever be multiple extract referrers with the same index, would there?
> Yes, I meant multiple `extract` referrers with the same index. I agree that we probably won't ever see this, but it wouldn't hurt to check for them.
Okay, done.

http://reviews.llvm.org/D6785

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list