[PATCH] [cmake/multilib] Teach llgo to respect the LLVM_LIBDIR_SUFFIX variable formultilib build and installs.

Peter Collingbourne peter at pcc.me.uk
Mon Dec 29 14:46:06 PST 2014


LGTM


================
Comment at: cmd/gllgo/gllgo.go:64
@@ -56,3 +63,3 @@
 	if opts.prefix != "" {
-		importPaths = append(importPaths, filepath.Join(opts.prefix, "lib", "go", "llgo-"+llvmVersion()))
+		importPaths = append(importPaths, filepath.Join(opts.prefix, "lib" + LibDirSuffix, "go", "llgo-"+llvmVersion()))
 	}
----------------
The formatting here looks inconsistent, did you run gofmt?

http://reviews.llvm.org/D6795

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list