[PATCH] Respect object format choice on Darwin
Jim Grosbach
grosbach at apple.com
Sat Dec 27 14:57:44 PST 2014
Glad to have a look. On holiday at the moment so if I don't get to it before then, please ping me on the 4th when I'm back at my desk where I have all the relevant bits available.
Jim
Sent from my iPhone
> On Dec 27, 2014, at 5:31 AM, Keno Fischer <kfischer at college.harvard.edu> wrote:
>
> Bumping with just the proposed change to remove `TT.isOSDarwin()`. Also putting @grosbach as the reviewer as suggested by @lhames.
>
>
> REPOSITORY
> rL LLVM
>
> http://reviews.llvm.org/D6185
>
> Files:
> lib/MC/MCObjectFileInfo.cpp
>
> Index: lib/MC/MCObjectFileInfo.cpp
> ===================================================================
> --- lib/MC/MCObjectFileInfo.cpp
> +++ lib/MC/MCObjectFileInfo.cpp
> @@ -868,7 +868,7 @@
> Arch == Triple::aarch64 ||
> Arch == Triple::ppc || Arch == Triple::ppc64 ||
> Arch == Triple::UnknownArch) &&
> - (TT.isOSDarwin() || TT.isOSBinFormatMachO())) {
> + TT.isOSBinFormatMachO()) {
> Env = IsMachO;
> InitMachOMCObjectFileInfo(TT);
> } else if ((Arch == Triple::x86 || Arch == Triple::x86_64 ||
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
> <D6185.17647.patch>
More information about the llvm-commits
mailing list